Re: [Qemu-devel] [PATCH] misc/aspeed_scu: Fix build error caused by missing header

[Peter Maydell]

On 27 June 2016 at 22:53, Pranith Kumar <address@hidden> wrote:
> Tracing configurations error out currently as follows:
>
> /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c: In function 
> ‘aspeed_scu_read’:
> /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c:130:9: error: implicit 
> declaration of function ‘qemu_log_mask’ 
> [-Werror=implicit-function-declaration]
> /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c:130:9: error: nested 
> extern declaration of ‘qemu_log_mask’ [-Werror=nested-externs]
> /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c:130:23: error: 
> ‘LOG_GUEST_ERROR’ undeclared (first use in this function)
> /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c:130:23: note: each 
> undeclared identifier is reported only once for each function it appears in
> /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c: In function 
> ‘aspeed_scu_write’:
> /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c:154:23: error: 
> ‘LOG_GUEST_ERROR’ undeclared (first use in this function)
>
> This is caused by a missing header file. Fix it.
>
> Signed-off-by: Pranith Kumar <address@hidden>
> ---
>  hw/misc/aspeed_scu.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c
> index 4f9df58..23f5175 100644
> --- a/hw/misc/aspeed_scu.c
> +++ b/hw/misc/aspeed_scu.c
> @@ -15,6 +15,7 @@
>  #include "qapi/error.h"
>  #include "qapi/visitor.h"
>  #include "qemu/bitops.h"
> +#include "qemu/log.h"
>  #include "trace.h"
>
>  #define TO_REG(offset) ((offset) >> 2)

Thanks; applied to master as a build fix.

-- PMM