Re: [Qemu-devel] [PATCH] nvdimm: fix memory leak in error code path

[Igor Mammedov]

On Tue, 28 Jun 2016 10:06:46 +0100
Stefan Hajnoczi <address@hidden> wrote:

> object_get_canonical_path_component() returns a heap-allocated string
> that must be freed using g_free().
> 
> Reported-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>

Reviewed-by: Igor Mammedov <address@hidden>

> ---
>  hw/mem/nvdimm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
> index 81896c0..7895805 100644
> --- a/hw/mem/nvdimm.c
> +++ b/hw/mem/nvdimm.c
> @@ -98,6 +98,7 @@ static void nvdimm_realize(PCDIMMDevice *dimm, Error **errp)
>                     "small to contain nvdimm label (0x%" PRIx64 ") and "
>                     "aligned PMEM (0x%" PRIx64 ")",
>                     path, memory_region_size(mr), nvdimm->label_size, align);
> +        g_free(path);
>          return;
>      }
>