[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/17] block: Convert bdrv_prwv_co() to BdrvChil
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH 16/17] block: Convert bdrv_prwv_co() to BdrvChild |
Date: |
Mon, 27 Jun 2016 17:19:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 21.06.2016 11:21, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/io.c | 37 +++++++++++++++++++++----------------
> 1 file changed, 21 insertions(+), 16 deletions(-)
>
> diff --git a/block/io.c b/block/io.c
> index 641cd49..78529fc 100644
> --- a/block/io.c
> +++ b/block/io.c
[...]
> @@ -2202,9 +2201,15 @@ void qemu_aio_unref(void *p)
> /**************************************************************/
> /* Coroutine block device emulation */
>
> +typedef struct FlushCo {
> + BlockDriverState *bs;
> + int ret;
> +} FlushCo;
> +
> +
> static void coroutine_fn bdrv_flush_co_entry(void *opaque)
> {
> - RwCo *rwco = opaque;
> + FlushCo *rwco = opaque;
>
> rwco->ret = bdrv_co_flush(rwco->bs);
> }
> @@ -2288,7 +2293,7 @@ out:
> int bdrv_flush(BlockDriverState *bs)
> {
> Coroutine *co;
> - RwCo rwco = {
> + FlushCo rwco = {
> .bs = bs,
> .ret = NOT_DONE,
> };
>
Renaming the variable to something other than rwco would make sense, but
I'll leave that up to you.
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 12/17] block: Convert bdrv_write() to BdrvChild, (continued)
- [Qemu-devel] [PATCH 06/17] block: Convert bdrv_aio_readv() to BdrvChild, Kevin Wolf, 2016/06/21
- [Qemu-devel] [PATCH 10/17] block: Use BlockBackend for I/O in bdrv_commit(), Kevin Wolf, 2016/06/21
- [Qemu-devel] [PATCH 09/17] block: Move bdrv_commit() to block/commit.c, Kevin Wolf, 2016/06/21
- [Qemu-devel] [PATCH 11/17] block: Convert bdrv_read() to BdrvChild, Kevin Wolf, 2016/06/21
- [Qemu-devel] [PATCH 16/17] block: Convert bdrv_prwv_co() to BdrvChild, Kevin Wolf, 2016/06/21
- Re: [Qemu-devel] [PATCH 16/17] block: Convert bdrv_prwv_co() to BdrvChild,
Max Reitz <=
- [Qemu-devel] [PATCH 13/17] block: Convert bdrv_pread(v) to BdrvChild, Kevin Wolf, 2016/06/21
- [Qemu-devel] [PATCH 17/17] block: Convert bdrv_co_preadv/pwritev to BdrvChild, Kevin Wolf, 2016/06/21
- [Qemu-devel] [PATCH 15/17] block: Convert bdrv_pwrite_zeroes() to BdrvChild, Kevin Wolf, 2016/06/21
- [Qemu-devel] [PATCH 14/17] block: Convert bdrv_pwrite(v/_sync) to BdrvChild, Kevin Wolf, 2016/06/21
- Re: [Qemu-devel] [PATCH 00/17] block: Convert common I/O path to BdrvChild, Paolo Bonzini, 2016/06/21