Re: [Qemu-devel] [PATCH 16/17] block: Convert bdrv_prwv_co() to BdrvChild

[Max Reitz]

On 21.06.2016 11:21, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/io.c | 37 +++++++++++++++++++++----------------
>  1 file changed, 21 insertions(+), 16 deletions(-)
> 
> diff --git a/block/io.c b/block/io.c
> index 641cd49..78529fc 100644
> --- a/block/io.c
> +++ b/block/io.c

[...]

> @@ -2202,9 +2201,15 @@ void qemu_aio_unref(void *p)
>  /**************************************************************/
>  /* Coroutine block device emulation */
>  
> +typedef struct FlushCo {
> +    BlockDriverState *bs;
> +    int ret;
> +} FlushCo;
> +
> +
>  static void coroutine_fn bdrv_flush_co_entry(void *opaque)
>  {
> -    RwCo *rwco = opaque;
> +    FlushCo *rwco = opaque;
>  
>      rwco->ret = bdrv_co_flush(rwco->bs);
>  }
> @@ -2288,7 +2293,7 @@ out:
>  int bdrv_flush(BlockDriverState *bs)
>  {
>      Coroutine *co;
> -    RwCo rwco = {
> +    FlushCo rwco = {
>          .bs = bs,
>          .ret = NOT_DONE,
>      };
> 

Renaming the variable to something other than rwco would make sense, but
I'll leave that up to you.

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature