[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 06/14] nbd: Send message along with server NB
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v4 06/14] nbd: Send message along with server NBD_REP_ERR errors |
Date: |
Mon, 27 Jun 2016 14:02:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 26/06/2016 00:15, Eric Blake wrote:
>
> +/* Send an error reply.
> + * Return -errno to kill connection, 0 to continue negotiation. */
> +static int GCC_FMT_ATTR(4, 5)
> + nbd_negotiate_send_rep_err(QIOChannel *ioc, uint32_t type,
> + uint32_t opt, const char *fmt, ...)
> +{
> + va_list va;
> + char *msg;
> + int ret;
> + size_t len;
> +
> + va_start(va, fmt);
> + msg = g_strdup_vprintf(fmt, va);
This leaks below.
Paolo
> + va_end(va);
> + len = strlen(msg);
> + assert(len < 4096);
> + TRACE("sending error message \"%s\"", msg);
> + ret = nbd_negotiate_send_rep_len(ioc, type, opt, len);
> + if (ret < 0) {
> + return ret;
> + }
> + if (nbd_negotiate_write(ioc, msg, len) != len) {
> + LOG("write failed (error message)");
> + return -EINVAL;
> + }
> + return 0;
- [Qemu-devel] [PATCH v4 00/14] nbd: efficient write zeroes, Eric Blake, 2016/06/25
- [Qemu-devel] [PATCH v4 01/14] nbd: Fix bad flag detection on server, Eric Blake, 2016/06/25
- [Qemu-devel] [PATCH v4 09/14] nbd: Let client skip portions of server reply, Eric Blake, 2016/06/25
- [Qemu-devel] [PATCH v4 06/14] nbd: Send message along with server NBD_REP_ERR errors, Eric Blake, 2016/06/25
- Re: [Qemu-devel] [PATCH v4 06/14] nbd: Send message along with server NBD_REP_ERR errors,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v4 11/14] nbd: Support shorter handshake, Eric Blake, 2016/06/25
- [Qemu-devel] [PATCH v4 04/14] nbd: Treat flags vs. command type as separate fields, Eric Blake, 2016/06/25
- [Qemu-devel] [PATCH v4 14/14] nbd: Implement NBD_CMD_WRITE_ZEROES on client, Eric Blake, 2016/06/25
- [Qemu-devel] [PATCH v4 07/14] nbd: Share common option-sending code in client, Eric Blake, 2016/06/25
- [Qemu-devel] [PATCH v4 05/14] nbd: Share common reply-sending code in server, Eric Blake, 2016/06/25
- [Qemu-devel] [PATCH v4 08/14] nbd: Let server know when client gives up negotiation, Eric Blake, 2016/06/25
- [Qemu-devel] [PATCH v4 10/14] nbd: Less allocation during NBD_OPT_LIST, Eric Blake, 2016/06/25