Re: [Qemu-devel] [PATCH 0/1] vhost-user: Add a protocol extension for client responses to vhost commands.

[Marc-André Lureau]

Hi

On Mon, Jun 27, 2016 at 12:45 PM, Felipe Franciosi <address@hidden> wrote:
>
>> On 24 Jun 2016, at 23:43, Michael S. Tsirkin <address@hidden> wrote:
>> I would like this structured like this:
>>
>> 1. fix races by sending GET_FEATURES and waiting for it
>
> We can still add this first if you think it will help. But is it worth it? 
> Asking for a reply to certain commands is clearly a better fix.


fwiw, I agree it's not worth, using GET_FEATURES is a hack (that I
used it in vhost-user-gpu rfc series) and could suffer the issues
Felipe described, unless the spec is constrained in backward
incompatible ways.


>
> Thanks,
> Felipe
>
>
>> 2. add VHOST_USER_PROTOCOL_F_REPLY_ACK
>>
>>
>>>
>>> Prerna Saxena (1):
>>>  vhost-user : Introduce a new feature, VHOST_USER_PROTOCOL_F_REPLY_ACK
>>>               This feature, if negotiated, forces the remote vhost-user
>>>               process to send a u64 reply containin status code for each
>>>               requested operation.
>>>               Status codes are '0' for success, and non-zero for error.
>>>
>>> docs/specs/vhost-user.txt |  36 +++++++++++
>>> hw/virtio/vhost-user.c    | 153 
>>> +++++++++++++++++++++++++++++++++++++++++++++-
>>> 2 files changed, 186 insertions(+), 3 deletions(-)
>>>
>>> --
>>> 1.8.1.2
>>>
>>
>
>



-- 
Marc-André Lureau