[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 12/23] vhost-user: check qemu_chr_fe_set_msgfds()
From: |
marcandre . lureau |
Subject: |
[Qemu-devel] [PATCH v2 12/23] vhost-user: check qemu_chr_fe_set_msgfds() return value |
Date: |
Fri, 24 Jun 2016 15:50:59 +0200 |
From: Marc-André Lureau <address@hidden>
Check return value, and drop the unnecessary 'if' check for fd_num.
Signed-off-by: Marc-André Lureau <address@hidden>
---
hw/virtio/vhost-user.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 495e09f..5dae496 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -187,8 +187,8 @@ static int vhost_user_write(struct vhost_dev *dev,
VhostUserMsg *msg,
return 0;
}
- if (fd_num) {
- qemu_chr_fe_set_msgfds(chr, fds, fd_num);
+ if (qemu_chr_fe_set_msgfds(chr, fds, fd_num) < 0) {
+ return -1;
}
return qemu_chr_fe_write_all(chr, (const uint8_t *) msg, size) == size ?
--
2.9.0
- [Qemu-devel] [PATCH v2 03/23] vhost: don't assume opaque is a fd, use backend cleanup, (continued)
- [Qemu-devel] [PATCH v2 03/23] vhost: don't assume opaque is a fd, use backend cleanup, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 08/23] vhost-net: always call vhost_dev_cleanup() on failure, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 04/23] vhost: make vhost_log_put() idempotent, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 05/23] vhost: call vhost_log_put() on cleanup, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 06/23] vhost: add vhost device only after all success, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 07/23] vhost: make vhost_dev_cleanup() idempotent, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 15/23] vhost-user: keep vhost_net after a disconnection, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 09/23] vhost: fix calling vhost_dev_cleanup() after vhost_dev_init(), marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 10/23] vhost: change some assert() for error_report() or silent fail, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 11/23] vhost: use error_report() instead of fprintf(stderr, ...), marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 12/23] vhost-user: check qemu_chr_fe_set_msgfds() return value,
marcandre . lureau <=
- [Qemu-devel] [PATCH v2 16/23] Revert "vhost-net: do not crash if backend is not present", marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 14/23] qemu-char: check socket is actually connected, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 18/23] vhost-net: success if backend has no ops->vhost_migration_done, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 17/23] get_vhost_net() should be != null after vhost_user_init, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 22/23] vhost-user: wait until backend init is completed, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 20/23] char: add chr_wait_connected callback, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 19/23] vhost: add assert() to check runtime behaviour, marcandre . lureau, 2016/06/24