Re: [Qemu-devel] [PATCH RFC 2/5] tests: New make target check-headers

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 06/23/2016 10:12 AM, Markus Armbruster wrote:
>> For each header "FOO.h", the test checks whether
>> 
>>      #include "qemu/osdep.h"
>>      #include "FOO.h"
>>      #include "FOO.h"
>> 
>> compiles.  A large number of headers don't pass this test, by design
>> or by accident.  These are all excluded with a blacklist for now.  Add
>> make target check-blacklisted-headers to help with examinating how
>
> s/examinating/examining/
>
>> they fail.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  tests/Makefile.include | 426 
>> +++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 426 insertions(+)
>> 
>> diff --git a/tests/Makefile.include b/tests/Makefile.include
>> index a2ed83b..e20f437 100644
>> --- a/tests/Makefile.include
>> +++ b/tests/Makefile.include
>> @@ -413,6 +413,421 @@ test-obj-y = tests/check-qint.o tests/check-qstring.o 
>> tests/check-qdict.o \
>>  $(test-obj-y): QEMU_INCLUDES += -Itests
>>  QEMU_CFLAGS += -I$(SRC_PATH)/tests
>>  
>> +# All headers
>> +headers := $(filter %.h, $(shell cd $(SRC_PATH) && git ls-files) 
>> $(GENERATED_HEADERS))
>
> Hard-coded to only work on a git checkout, but I guess that's okay.

I'll mention it in the commit message.