[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 10/10] m25p80: Fix WINBOND fast read command hand
From: |
marcin.krzeminski |
Subject: |
[Qemu-devel] [PATCH v3 10/10] m25p80: Fix WINBOND fast read command handling |
Date: |
Fri, 24 Jun 2016 10:07:11 +0200 |
From: Marcin Krzeminski <address@hidden>
This commit fix obvious bug in WINBOND command handling.
Datasheet states that default dummy cycles is 8 so fix it.
Signed-off-by: Marcin Krzeminski <address@hidden>
---
hw/block/m25p80.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index ca5320f..5ab22c4 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -738,6 +738,9 @@ static void decode_fast_read_cmd(Flash *s)
s->needed_bytes = get_addr_length(s);
switch (get_man(s)) {
/* Dummy cycles - modeled with bytes writes instead of bits */
+ case MAN_WINBOND:
+ s->needed_bytes += 8;
+ break;
case MAN_NUMONYX:
s->needed_bytes += extract32(s->volatile_cfg, 4, 4);
break;
@@ -768,7 +771,7 @@ static void decode_dio_read_cmd(Flash *s)
/* Dummy cycles modeled with bytes writes instead of bits */
switch (get_man(s)) {
case MAN_WINBOND:
- s->needed_bytes = 4;
+ s->needed_bytes += 8;
break;
case MAN_SPANSION:
s->needed_bytes += SPANSION_CONTINUOUS_READ_MODE_CMD_LEN;
@@ -807,7 +810,7 @@ static void decode_qio_read_cmd(Flash *s)
/* Dummy cycles modeled with bytes writes instead of bits */
switch (get_man(s)) {
case MAN_WINBOND:
- s->needed_bytes = 6;
+ s->needed_bytes += 8;
break;
case MAN_SPANSION:
s->needed_bytes += SPANSION_CONTINUOUS_READ_MODE_CMD_LEN;
--
2.7.4
- [Qemu-devel] [PATCH v3 00/10] m25p80: Add new 512Mbit and 1Gbit devices, marcin.krzeminski, 2016/06/24
- [Qemu-devel] [PATCH v3 04/10] m25p80: Introduce COLLECTING_VAR_LEN_DATA state., marcin.krzeminski, 2016/06/24
- [Qemu-devel] [PATCH v3 10/10] m25p80: Fix WINBOND fast read command handling,
marcin.krzeminski <=
- [Qemu-devel] [PATCH v3 01/10] m25p80: Replace JEDEC ID masking with function., marcin.krzeminski, 2016/06/24
- [Qemu-devel] [PATCH v3 02/10] m25p80: Make a table for JEDEC ID., marcin.krzeminski, 2016/06/24
- [Qemu-devel] [PATCH v3 07/10] m25p80: Introduce configuration registers., marcin.krzeminski, 2016/06/24
- [Qemu-devel] [PATCH v3 03/10] m25p80: Allow more than four banks., marcin.krzeminski, 2016/06/24
- [Qemu-devel] [PATCH v3 08/10] m25p80: Fast read commands family changes., marcin.krzeminski, 2016/06/24
- [Qemu-devel] [PATCH v3 09/10] m25p80: New flash devices., marcin.krzeminski, 2016/06/24
- [Qemu-devel] [PATCH v3 06/10] m25p80: Introduce quad and equad modes., marcin.krzeminski, 2016/06/24
- [Qemu-devel] [PATCH v3 05/10] m25p80: Add additional flash commands:, marcin.krzeminski, 2016/06/24
- Re: [Qemu-devel] [PATCH v3 00/10] m25p80: Add new 512Mbit and 1Gbit devices, Peter Maydell, 2016/06/27