qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 5/5] tests: add a m25p80 test


From: Cédric Le Goater
Subject: Re: [Qemu-devel] [PATCH v3 5/5] tests: add a m25p80 test
Date: Thu, 23 Jun 2016 21:09:24 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0

On 06/23/2016 08:52 PM, Peter Maydell wrote:
> On 23 June 2016 at 17:33, Cédric Le Goater <address@hidden> wrote:
>> This test uses the palmetto platform and the AST2400 SPI controller to
>> test the m25p80 flash module device model. The flash model is defined
>> by the platform (n25q256a) and it would be nice to find way to control
>> it, using a property probably.
>>
>> Signed-off-by: Cédric Le Goater <address@hidden>
>> ---
> 
> Reviewed-by: Peter Maydell <address@hidden>
> 
> Are you in a position to check this test passes on both a
> bigendian and little endian host? I have no specific reason
> to think it will fail, but it seems worth checking.
> (If not, it'll get tested when I do a merge eventually.)

I can do bigendian on a p7/ppc64 host. I will check that when 
I have addressed all your comments.

Thanks for the review.

C.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]