[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 3/6] serial: separate serial_xmit and serial_watc
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH v2 3/6] serial: separate serial_xmit and serial_watch_cb |
Date: |
Thu, 23 Jun 2016 19:22:16 +0200 |
serial_xmit starts transmission of whatever is in the transmitter
register, THR or FIFO; serial_watch_cb is a wrapper around it and is
only used as a qemu_chr_fe_add_watch callback.
Tested-by: Bret Ketchum <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/char/serial.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/hw/char/serial.c b/hw/char/serial.c
index 904b218..0b09094 100644
--- a/hw/char/serial.c
+++ b/hw/char/serial.c
@@ -106,6 +106,7 @@ do {} while (0)
#endif
static void serial_receive1(void *opaque, const uint8_t *buf, int size);
+static void serial_xmit(SerialState *s);
static inline void recv_fifo_put(SerialState *s, uint8_t chr)
{
@@ -223,10 +224,16 @@ static void serial_update_msl(SerialState *s)
}
}
-static gboolean serial_xmit(GIOChannel *chan, GIOCondition cond, void *opaque)
+static gboolean serial_watch_cb(GIOChannel *chan, GIOCondition cond,
+ void *opaque)
{
SerialState *s = opaque;
+ serial_xmit(s);
+ return FALSE;
+}
+static void serial_xmit(SerialState *s)
+{
do {
assert(!(s->lsr & UART_LSR_TEMT));
if (s->tsr_retry == 0) {
@@ -254,9 +261,9 @@ static gboolean serial_xmit(GIOChannel *chan, GIOCondition
cond, void *opaque)
} else if (qemu_chr_fe_write(s->chr, &s->tsr, 1) != 1) {
if (s->tsr_retry < MAX_XMIT_RETRY &&
qemu_chr_fe_add_watch(s->chr, G_IO_OUT|G_IO_HUP,
- serial_xmit, s) > 0) {
+ serial_watch_cb, s) > 0) {
s->tsr_retry++;
- return FALSE;
+ return;
}
}
s->tsr_retry = 0;
@@ -267,11 +274,8 @@ static gboolean serial_xmit(GIOChannel *chan, GIOCondition
cond, void *opaque)
s->last_xmit_ts = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
s->lsr |= UART_LSR_TEMT;
-
- return FALSE;
}
-
/* Setter for FCR.
is_load flag means, that value is set while loading VM state
and interrupt should not be invoked */
@@ -329,7 +333,7 @@ static void serial_ioport_write(void *opaque, hwaddr addr,
uint64_t val,
s->lsr &= ~UART_LSR_TEMT;
serial_update_irq(s);
if (s->tsr_retry == 0) {
- serial_xmit(NULL, G_IO_OUT, s);
+ serial_xmit(s);
}
}
break;
--
2.5.5
- [Qemu-devel] [PATCH v2 0/6] serial: flow control fixes, Paolo Bonzini, 2016/06/23
- [Qemu-devel] [PATCH v2 1/6] serial: make tsr_retry unsigned, Paolo Bonzini, 2016/06/23
- [Qemu-devel] [PATCH v2 5/6] serial: remove watch on reset, Paolo Bonzini, 2016/06/23
- [Qemu-devel] [PATCH v2 4/6] char: change qemu_chr_fe_add_watch to return unsigned, Paolo Bonzini, 2016/06/23
- [Qemu-devel] [PATCH v2 2/6] serial: simplify tsr_retry reset, Paolo Bonzini, 2016/06/23
- [Qemu-devel] [PATCH v2 3/6] serial: separate serial_xmit and serial_watch_cb,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v2 6/6] serial: reinstate watch after migration, Paolo Bonzini, 2016/06/23
- Re: [Qemu-devel] [PATCH v2 0/6] serial: flow control fixes, Dr. David Alan Gilbert, 2016/06/24