Re: [Qemu-devel] [PATCH v9 04/10] softfloat: For Mips only, correct order in pickNaNMulAdd()

[Peter Maydell]

On 10 June 2016 at 10:57, Aleksandar Markovic
<address@hidden> wrote:
> From: Aleksandar Markovic <address@hidden>
>
> Only for Mips platform, and only for cases when snan_bit_is_one is 0,
> correct the order of argument comparisons in pickNaNMulAdd().
>
> For more info, see [1], page 53, section "3.5.3 NaN Propagation".
>
> [1] "MIPS Architecture for Programmers Volume IV-j:
>     The MIPS32 SIMD Architecture Module",
>     Imagination Technologies LTD, Revision 1.12, February 3, 2016
>
> Reviewed-by: Leon Alrae <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>

I think the subject line of this commit message would be a little
clearer as
  softfloat: Handle snan_bit_is_one == 0 in MIPS pickNaNMulAdd()

Otherwise:
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM