[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/10] vl: Reject invalid class names on -glo
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/10] vl: Reject invalid class names on -global |
Date: |
Thu, 23 Jun 2016 08:45:15 -0300 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Mon, Jun 20, 2016 at 12:52:56PM -0300, Eduardo Habkost wrote:
> Instead of just printing a warning very late, reject obviously
> invalid -global arguments by validating the class name.
>
> Update test-qdev-global-props to not expect class name validation
> to be performed in qdev_prop_check_globals().
Added the following to the commit message:
The checks for the warnings in tests/test-qdev-global-props.c
are being removed. Unfortunately, adding unit tests for vl.c
would be quite difficult.
>
> Reviewed-by: Markus Armbruster <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> Changes v1 -> v2:
> * Fix test-qdev-global-props unit test
> * Simplify object_dynamic_cast() check
> * Suggested-by: Markus Armbruster <address@hidden>
--
Eduardo
- [Qemu-devel] [PATCH v2 00/10] globals: Clean up validation and error checking, Eduardo Habkost, 2016/06/20
- [Qemu-devel] [PATCH v2 01/10] qdev: Don't stop applying globals on first error, Eduardo Habkost, 2016/06/20
- [Qemu-devel] [PATCH v2 02/10] qdev: Eliminate qemu_add_globals() function, Eduardo Habkost, 2016/06/20
- [Qemu-devel] [PATCH v2 05/10] machine: Add machine_register_compat_props() function, Eduardo Habkost, 2016/06/20
- [Qemu-devel] [PATCH v2 08/10] qdev: Eliminate GlobalProperty 'used' and 'user_provided' fields, Eduardo Habkost, 2016/06/20
- [Qemu-devel] [PATCH v2 06/10] vl: Set errp to &error_abort on machine compat_props, Eduardo Habkost, 2016/06/20