Re: [Qemu-devel] [PATCH v2 01/10] qdev: Don't stop applying globals on first error

[Eduardo Habkost]

On Thu, Jun 23, 2016 at 09:40:54AM +0200, Markus Armbruster wrote:
> Eduardo Habkost <address@hidden> writes:
> 
> > Since commit 25f8dd9, qdev_prop_set_globals_for_type() stops
> > applying global properties on the first error. It is a leftover
> > from when QEMU exited on any error when applying global property.
> > Now we print a warning about the first error, bug ignore all
> > other global properties after it.
> 
> Actually, we've stopped since forever.  Before commit 25f8dd9, that was
> okay.  Since commit, it isn't.  Suggest:
> 
> qdev_prop_set_globals_for_type() stops applying global properties on the
> first error.  It is a leftover from when QEMU exited on any error when
> applying global property.  Commit 25f8dd9 changed the fatal error to a
> warning, but neglected to drop the stopping.  Fix that.

Fixed that. Thanks!

-- 
Eduardo