[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] serial: simplify tsr_retry reset
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] serial: simplify tsr_retry reset |
Date: |
Wed, 22 Jun 2016 16:12:50 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
* Paolo Bonzini (address@hidden) wrote:
> Move common code outside the if, and reset tsr_retry even in loopback mode.
> Right now it cannot become non-zero, but it will be possible as soon as
> we start respecting the baud rate.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> hw/char/serial.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/char/serial.c b/hw/char/serial.c
> index 4196a2e..d232473 100644
> --- a/hw/char/serial.c
> +++ b/hw/char/serial.c
> @@ -265,10 +265,8 @@ static void serial_xmit(SerialState *s)
> s->tsr_retry++;
> return;
> }
> - s->tsr_retry = 0;
> - } else {
> - s->tsr_retry = 0;
> }
> + s->tsr_retry = 0;
>
> /* Transmit another byte if it is already available. It is only
> possible when FIFO is enabled and not empty. */
> --
> 2.5.5
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK