Re: [Qemu-devel] [PATCH] target-i386: avoid using locals outside their scope

[Igor Mammedov]

On Tue, 21 Jun 2016 14:04:40 +0200
Paolo Bonzini <address@hidden> wrote:

> x86_cpu_parse_featurestr has a "val = num;" assignment just before num
> goes out of scope.  Push num up to fix the issue.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>

> ---
>  target-i386/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 2227f22..0b286e1 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1975,6 +1975,7 @@ static void x86_cpu_parse_featurestr(CPUState
> *cs, char *features, const char *name;
>          const char *val = NULL;
>          char *eq = NULL;
> +        char num[32];
>  
>          /* Compatibility syntax: */
>          if (featurestr[0] == '+') {
> @@ -2000,7 +2001,6 @@ static void x86_cpu_parse_featurestr(CPUState
> *cs, char *features, if (!strcmp(name, "tsc-freq")) {
>              int64_t tsc_freq;
>              char *err;
> -            char num[32];
>  
>              tsc_freq = qemu_strtosz_suffix_unit(val, &err,
>                                             QEMU_STRTOSZ_DEFSUFFIX_B,
> 1000);