[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/5] hw/net/virtio-net.c: Don't use *_to_cpup()
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 4/5] hw/net/virtio-net.c: Don't use *_to_cpup() |
Date: |
Thu, 16 Jun 2016 18:17:25 +0100 |
Don't use *_to_cpup() to do byte-swapped loads; instead use
ld*_p() which correctly handle misaligned accesses.
Signed-off-by: Peter Maydell <address@hidden>
---
hw/net/virtio-net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 5798f87..7e6a60a 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -1051,7 +1051,7 @@ static int receive_filter(VirtIONet *n, const uint8_t
*buf, int size)
ptr += n->host_hdr_len;
if (!memcmp(&ptr[12], vlan, sizeof(vlan))) {
- int vid = be16_to_cpup((uint16_t *)(ptr + 14)) & 0xfff;
+ int vid = lduw_be_p(ptr + 14) & 0xfff;
if (!(n->vlans[vid >> 5] & (1U << (vid & 0x1f))))
return 0;
}
--
1.9.1
- [Qemu-devel] [PATCH 0/5] hw/net: Don't use cpu_to_*w() and *_to_cpup(), Peter Maydell, 2016/06/16
- [Qemu-devel] [PATCH 2/5] hw/net/rtl8139.c: Don't use *_to_cpup(), Peter Maydell, 2016/06/16
- [Qemu-devel] [PATCH 1/5] hw/net/eepro100.c: Don't use cpu_to_*w() and *_to_cpup(), Peter Maydell, 2016/06/16
- [Qemu-devel] [PATCH 4/5] hw/net/virtio-net.c: Don't use *_to_cpup(),
Peter Maydell <=
- [Qemu-devel] [PATCH 3/5] hw/net/rocker: Don't use *_to_cpup(), Peter Maydell, 2016/06/16
- [Qemu-devel] [PATCH 5/5] hw/net/e1000: Don't use *_to_cpup(), Peter Maydell, 2016/06/16
- Re: [Qemu-devel] [PATCH 0/5] hw/net: Don't use cpu_to_*w() and *_to_cpup(), Richard Henderson, 2016/06/17
- Re: [Qemu-devel] [PATCH 0/5] hw/net: Don't use cpu_to_*w() and *_to_cpup(), Jason Wang, 2016/06/19
- Re: [Qemu-devel] [PATCH 0/5] hw/net: Don't use cpu_to_*w() and *_to_cpup(), Peter Maydell, 2016/06/27