[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 06/14] block/nbd: Add nbd_has_filename_option
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 06/14] block/nbd: Add nbd_has_filename_options_conflict() |
Date: |
Tue, 14 Jun 2016 16:54:42 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 04/06/2016 12:28 PM, Max Reitz wrote:
> Right now, we have four possible options that conflict with specifying
> an NBD filename, and a future patch will add another one ("address").
> This future option is a nested QDict that is flattened at this point,
> requiring as to test each option whether its key has an "address."
> prefix. Therefore, we will then need to iterate through all options.
>
> Adding this iteration logic now will simplify adding the new option
> later. A nice side effect is that the user will not receive a long list
> of five options which are not supposed to be specified with a filename,
> but we can actually print the problematic option.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/nbd.c | 26 ++++++++++++++++++++------
> 1 file changed, 20 insertions(+), 6 deletions(-)
>
> diff --git a/block/nbd.c b/block/nbd.c
> index d12bcc6..1736f68 100644
> --- a/block/nbd.c
> +++ b/block/nbd.c
> @@ -120,6 +120,25 @@ out:
> return ret;
> }
>
> +static bool nbd_has_filename_options_conflict(QDict *options, Error **errp)
> +{
> + const QDictEntry *e;
> +
> + for (e = qdict_first(options); e; e = qdict_next(options, e)) {
> + if (!strcmp(e->key, "host")
> + || !strcmp(e->key, "port")
I know there are already instances of breaking before || in this file,
but most of qemu breaks after, as in:
if (!strcmp(e->key, "host") ||
!strcmp(e->key, "port") ||
...
But choice of formatting is trivial, so:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 06/14] block/nbd: Add nbd_has_filename_options_conflict(),
Eric Blake <=