[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 10/10] target-i386: Print obsolete warnings if +-
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 10/10] target-i386: Print obsolete warnings if +-features are used |
Date: |
Tue, 14 Jun 2016 17:16:40 -0400 (EDT) |
----- Original Message -----
> From: "Eduardo Habkost" <address@hidden>
> To: "Peter Maydell" <address@hidden>
> Cc: "Andreas Färber" <address@hidden>, address@hidden, "Richard Henderson"
> <address@hidden>, "Paolo
> Bonzini" <address@hidden>, "Igor Mammedov" <address@hidden>
> Sent: Tuesday, June 14, 2016 10:59:08 PM
> Subject: [PULL 10/10] target-i386: Print obsolete warnings if +-features are
> used
>
> From: Igor Mammedov <address@hidden>
>
> Signed-off-by: Igor Mammedov <address@hidden>
> [ehabkost: Changed to use error_report()]
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> target-i386/cpu.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 3665fec..baa3783 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1980,9 +1980,15 @@ static void x86_cpu_parse_featurestr(CPUState *cs,
> char *features,
> /* Compatibility syntax: */
> if (featurestr[0] == '+') {
> add_flagname_to_bitmaps(featurestr + 1, plus_features,
> &local_err);
> + error_report(
> + "'+%s' is obsolete and will be removed in future, use
> '%s=on'",
> + featurestr + 1, featurestr + 1);
> continue;
> } else if (featurestr[0] == '-') {
> add_flagname_to_bitmaps(featurestr + 1, minus_features,
> &local_err);
> + error_report(
> + "'-%s' is obsolete and will be removed in future, use
> '%s=off'",
> + featurestr + 1, featurestr + 1);
> continue;
> }
I still disagree with this change.
Paolo
- [Qemu-devel] [PULL 02/10] pc: Add 2.7 machine, (continued)
- [Qemu-devel] [PULL 02/10] pc: Add 2.7 machine, Eduardo Habkost, 2016/06/14
- [Qemu-devel] [PULL 03/10] target-i386: Implement CPUID[0xB] (Extended Topology Enumeration), Eduardo Habkost, 2016/06/14
- [Qemu-devel] [PULL 01/10] target-i386: add Skylake-Client cpu model, Eduardo Habkost, 2016/06/14
- [Qemu-devel] [PULL 05/10] target-i386: Move features logic that requires CPUState to realize time, Eduardo Habkost, 2016/06/14
- [Qemu-devel] [PULL 07/10] target-i386: Move xcc->kvm_required check to realize time, Eduardo Habkost, 2016/06/14
- [Qemu-devel] [PULL 04/10] target-i386: Remove xlevel & hv-spinlocks option fixups, Eduardo Habkost, 2016/06/14
- [Qemu-devel] [PULL 08/10] target-i386: Use cpu_generic_init() in cpu_x86_init(), Eduardo Habkost, 2016/06/14
- [Qemu-devel] [PULL 06/10] target-i386: Remove assert(kvm_enabled()) from host_x86_cpu_initfn(), Eduardo Habkost, 2016/06/14
- [Qemu-devel] [PULL 09/10] target-i386: Consolidate calls of object_property_parse() in x86_cpu_parse_featurestr, Eduardo Habkost, 2016/06/14
- [Qemu-devel] [PULL 10/10] target-i386: Print obsolete warnings if +-features are used, Eduardo Habkost, 2016/06/14
- Re: [Qemu-devel] [PULL 10/10] target-i386: Print obsolete warnings if +-features are used,
Paolo Bonzini <=
Re: [Qemu-devel] [PULL 00/10] X86 queue, 2016-06-14, Eduardo Habkost, 2016/06/14