[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] libqos: add qvirtqueue_cleanup()
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] libqos: add qvirtqueue_cleanup() |
Date: |
Tue, 14 Jun 2016 09:54:06 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Thu, May 05, 2016 at 04:53:35PM +0100, Stefan Hajnoczi wrote:
> qvirtqueue_setup() allocates the vring and virtqueue state. So far
> there has been no function to free it. Callers have been using
> guest_free() for the vring but forgot to free the QVirtQueue state.
>
> This patch solves the memory leak by introducing qvirtqueue_cleanup().
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> This fix is based on based on "[PATCH 0/5] libqos: add ability to pop buffers
> from virtqueue" but probably applies more or less cleanly onto other trees
> too.
> Also available on my vsock tree:
> https://github.com/stefanha/qemu/commits/vsock.
>
> tests/libqos/virtio-mmio.c | 8 ++++++++
> tests/libqos/virtio-pci.c | 10 ++++++++++
> tests/libqos/virtio.c | 6 ++++++
> tests/libqos/virtio.h | 5 +++++
> tests/virtio-blk-test.c | 10 +++++-----
> tests/virtio-net-test.c | 2 +-
> tests/virtio-scsi-test.c | 2 +-
> 7 files changed, 36 insertions(+), 7 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
signature.asc
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] libqos: add qvirtqueue_cleanup(),
Stefan Hajnoczi <=