|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [PATCH v6 09/11] target-avr: updating translate.c to use instructions translation |
| Date: | Mon, 13 Jun 2016 09:08:21 -0700 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 06/12/2016 12:01 PM, Michael Rolnik wrote:
+ /* target is defined as bigendian for push_ret/pop_ret + optimization. but my decode assumes instruction to be in little + endian format, hence bswap + */ + inst->opcode = bswap32(inst->opcode);
You don't have to do that. Indeed, you shouldn't.Note in my reply to patch 8, how one can individually specify a big-endian load for one memory operation.
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |