[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Xen-devel] [PULL 3/4] xen: add pvUSB backend
|
From: |
Juergen Gross |
|
Subject: |
Re: [Qemu-devel] [Xen-devel] [PULL 3/4] xen: add pvUSB backend |
|
Date: |
Mon, 13 Jun 2016 09:55:01 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 |
On 10/06/16 12:38, Gerd Hoffmann wrote:
> On Di, 2016-06-07 at 10:35 +0200, Olaf Hering wrote:
>> On Mon, May 23, Gerd Hoffmann wrote:
>>
>>> +++ b/hw/usb/Makefile.objs
>>> +common-obj-$(CONFIG_XEN_BACKEND) += xen-usb.o
>>> +++ b/hw/usb/xen-usb.c
>>> + usb_bus_new(&usbif->bus, sizeof(usbif->bus), &xen_usb_bus_ops,
>>> xen_sysdev);
>>
>> xen_sysdev is in an i386-only file, as a result qemu fails to link.
>
> Ping. Juergen? Xen folks? Can anyone have a look please?
Sorry, just was 3 weeks offline due to moving across Germany (900 km).
> I think the fix would be s/xen_sysdev/xendev/, but I can't test that
> myself.
I think the proper solution is to move the xen_sysdev definition and
initialization from hw/xenpv/xen_machine_pv.c to hw/xen/xen_backend.c
I'll send a patch.
Juergen