[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] error: Remove NULL checks on error_propa
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] error: Remove NULL checks on error_propagate() calls |
Date: |
Mon, 13 Jun 2016 09:41:09 +0200 |
On Fri, 10 Jun 2016 17:12:16 -0300
Eduardo Habkost <address@hidden> wrote:
> error_propagate() already ignores local_err==NULL, so there's no
> need to check it before calling.
>
> Coccinelle patch used to perform the changes added to
> scripts/coccinelle/error_propagate_null.cocci.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> block.c | 20 +++++--------------
> block/qcow2.c | 4 +---
> block/quorum.c | 4 +---
> block/raw-posix.c | 16 ++++-----------
> block/raw_bsd.c | 4 +---
> block/snapshot.c | 4 +---
> blockdev.c | 12 +++---------
> bootdevice.c | 4 +---
> dump.c | 4 +---
> hw/ide/qdev.c | 4 +---
> hw/net/ne2000-isa.c | 4 +---
> hw/s390x/virtio-ccw.c | 28
> +++++++--------------------
For virtio-ccw:
Acked-by: Cornelia Huck <address@hidden>
> hw/usb/dev-storage.c | 4 +---
> qga/commands-win32.c | 8 ++------
> qom/object.c | 4 +---
> scripts/coccinelle/error_propagate_null.cocci | 10 ++++++++++
> 16 files changed, 41 insertions(+), 93 deletions(-)
> create mode 100644 scripts/coccinelle/error_propagate_null.cocci
- [Qemu-devel] [PATCH v2 0/3] coccinelle: Clean up error checks and return value variables, Eduardo Habkost, 2016/06/10
- [Qemu-devel] [PATCH v2 1/3] error: Remove NULL checks on error_propagate() calls, Eduardo Habkost, 2016/06/10
- [Qemu-devel] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Eduardo Habkost, 2016/06/10
- Re: [Qemu-devel] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Eric Blake, 2016/06/10
- Re: [Qemu-devel] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Cornelia Huck, 2016/06/13
- Re: [Qemu-devel] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Markus Armbruster, 2016/06/13
- Re: [Qemu-devel] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Eduardo Habkost, 2016/06/13
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Eric Blake, 2016/06/13
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Markus Armbruster, 2016/06/13
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Eduardo Habkost, 2016/06/13
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Markus Armbruster, 2016/06/14