[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 05/13] register: QOMify
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v6 05/13] register: QOMify |
Date: |
Fri, 10 Jun 2016 11:55:51 +0100 |
On 12 May 2016 at 23:46, Alistair Francis <address@hidden> wrote:
> From: Peter Crosthwaite <address@hidden>
>
> QOMify registers as a child of TYPE_DEVICE. This allows registers to
> define GPIOs.
>
> Define an init helper that will do QOM initialisation.
You should just squash this down into patch 2.
> Signed-off-by: Peter Crosthwaite <address@hidden>
> Signed-off-by: Alistair Francis <address@hidden>
> Reviewed-by: KONRAD Frederic <address@hidden>
> ---
> /**
> + * Initialize a register. GPIO's are setup as IOs to the specified device.
> + * Fast paths for eligible registers are enabled.
> + * @reg: Register to initialize
> + */
I can't work out what this documentation comment is trying to say.
How can a register have a GPIO? What does a fast path do, what
registers are elegible, why do I care whether they're enabled or not?
> +
> +void register_init(RegisterInfo *reg);
> +
> +/**
> * Memory API MMIO write handler that will write to a Register API register.
> * _be for big endian variant and _le for little endian.
> * @opaque: RegisterInfo to write to
> --
> 2.7.4
thanks
-- PMM
- Re: [Qemu-devel] [PATCH v6 05/13] register: QOMify,
Peter Maydell <=