[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/5] vnc: drop unused depth arg for set_pixel_format
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 1/5] vnc: drop unused depth arg for set_pixel_format |
Date: |
Fri, 10 Jun 2016 11:58:38 +0200 |
Spotted by Coverity.
Cc: Paolo Bonzini <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden
---
ui/vnc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index c862fdc..942cfb9 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -2115,8 +2115,7 @@ static void send_color_map(VncState *vs)
}
}
-static void set_pixel_format(VncState *vs,
- int bits_per_pixel, int depth,
+static void set_pixel_format(VncState *vs, int bits_per_pixel,
int big_endian_flag, int true_color_flag,
int red_max, int green_max, int blue_max,
int red_shift, int green_shift, int blue_shift)
@@ -2124,7 +2123,6 @@ static void set_pixel_format(VncState *vs,
if (!true_color_flag) {
/* Expose a reasonable default 256 color map */
bits_per_pixel = 8;
- depth = 8;
red_max = 7;
green_max = 7;
blue_max = 3;
@@ -2231,7 +2229,7 @@ static int protocol_client_msg(VncState *vs, uint8_t
*data, size_t len)
if (len == 1)
return 20;
- set_pixel_format(vs, read_u8(data, 4), read_u8(data, 5),
+ set_pixel_format(vs, read_u8(data, 4),
read_u8(data, 6), read_u8(data, 7),
read_u16(data, 8), read_u16(data, 10),
read_u16(data, 12), read_u8(data, 14),
--
1.8.3.1
- [Qemu-devel] [PULL 0/5] ui: misc bug fixes, Gerd Hoffmann, 2016/06/10
- [Qemu-devel] [PULL 4/5] ui/console-gl: Add support for big endian display surfaces, Gerd Hoffmann, 2016/06/10
- [Qemu-devel] [PULL 3/5] gtk: fix vte version check, Gerd Hoffmann, 2016/06/10
- [Qemu-devel] [PULL 5/5] console: ignore ui_info updates which don't actually update something, Gerd Hoffmann, 2016/06/10
- [Qemu-devel] [PULL 1/5] vnc: drop unused depth arg for set_pixel_format,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 2/5] ui: fix regression in printing VNC host/port on startup, Gerd Hoffmann, 2016/06/10
- Re: [Qemu-devel] [PULL 0/5] ui: misc bug fixes, Peter Maydell, 2016/06/10