[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/10] tests/vhost-user-bridge: workaround stale
|
From: |
Marc-André Lureau |
|
Subject: |
Re: [Qemu-devel] [PATCH 03/10] tests/vhost-user-bridge: workaround stale vring base |
|
Date: |
Thu, 9 Jun 2016 12:25:54 +0200 |
Hi
On Thu, Jun 9, 2016 at 12:07 PM, Victor Kaplansky <address@hidden> wrote:
> What if set_vring_base is called after set_vring_addr?
> Maybe it is worth to add the fixup to the set_vring_base as well?
It would need to handle conditions like set_vring_base() being called
while set_vring_addr() is not yet, and thus vq->used isn't set.
Imho it's not necessary, since order is currently fixed in
vhost_virtqueue_start(), but we could specify this in the protocol to
avoid too much possible states.
--
Marc-André Lureau
- [Qemu-devel] [PATCH 00/10] vhost-user: simple reconnection support, marcandre . lureau, 2016/06/06
- [Qemu-devel] [PATCH 02/10] tests/vhost-user-bridge: add client mode, marcandre . lureau, 2016/06/06
- [Qemu-devel] [PATCH 04/10] qemu-char: add qemu_chr_disconnect to close a fd accepted by listen fd, marcandre . lureau, 2016/06/06
- [Qemu-devel] [PATCH 05/10] vhost-user: disconnect on start failure, marcandre . lureau, 2016/06/06
- [Qemu-devel] [PATCH 07/10] vhost-net: save & restore vhost-user acked features, marcandre . lureau, 2016/06/06
- [Qemu-devel] [PATCH 06/10] vhost-net: do not crash if backend is not present, marcandre . lureau, 2016/06/06
- [Qemu-devel] [PATCH 08/10] vhost-net: save & restore vring enable state, marcandre . lureau, 2016/06/06
- [Qemu-devel] [PATCH 09/10] tests: append i386 tests, marcandre . lureau, 2016/06/06