[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/10] arm: virt: parse cpu_model only once
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 09/10] arm: virt: parse cpu_model only once |
Date: |
Wed, 8 Jun 2016 18:25:36 +0100 |
On 8 June 2016 at 17:55, Eduardo Habkost <address@hidden> wrote:
> On Mon, Jun 06, 2016 at 05:16:51PM +0200, Igor Mammedov wrote:
>> considering that features are converted to
>> global properties and global properties are
>> automatically applied to every new instance
>> of created CPU (at object_new() time), there
>> is no point in parsing cpu_model string every
>> time a CPU created.
>> So move parsing outside CPU creation loop and
>> do it only once.
>> Parsing also should be done before any CPU is
>> created so that features would affect the first
>> CPU a well.
>>
>> Signed-off-by: Igor Mammedov <address@hidden>
>
> Peter, do you prefer to get this included through my tree with
> the rest of the series, or wait to included it in your tree after
> the other patches get merged to master?
Seems easiest for you to take it.
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH 10/10] pc: parse cpu features only once, (continued)
- [Qemu-devel] [PATCH 10/10] pc: parse cpu features only once, Igor Mammedov, 2016/06/06
- [Qemu-devel] [PATCH 05/10] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr, Igor Mammedov, 2016/06/06
- [Qemu-devel] [PATCH 07/10] target-sparc: cpu: use sparc_cpu_parse_features() directly, Igor Mammedov, 2016/06/06
- [Qemu-devel] [PATCH 08/10] cpu: use CPUClass->parse_features() as convertor to global properties, Igor Mammedov, 2016/06/06
- [Qemu-devel] [PATCH 09/10] arm: virt: parse cpu_model only once, Igor Mammedov, 2016/06/06