Re: [Qemu-devel] [RFC PATCH] configure: Enable -Werror for MinGW builds, too

[Daniel P. Berrange]

On Wed, Jun 08, 2016 at 10:13:26AM +0200, Thomas Huth wrote:
> MinGW seems to compile currently without warnings, so it should
> be safe to enable -Werror now for this environment, too.
> 
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  ... at least it compiles without errors for me here. I hope that's
>  also true for different versions of MinGW ... would be great if
>  everybody who has such a compiler installed could give it a try!

Heh, I have created exactly the same patch locally myself a few
months back after noticed that Mingw was now warning-free. I
never got around to sending it for some reason :-) I confirm that
it is still warning free today, on Fedora 23, x86_64 host.

> 
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 4627d2c..2e5b818 100755
> --- a/configure
> +++ b/configure
> @@ -1393,7 +1393,7 @@ z_version=$(cut -f3 -d. $source_path/VERSION)
>  
>  if test -z "$werror" ; then
>      if test -d "$source_path/.git" -a \
> -        "$linux" = "yes" ; then
> +        \( "$linux" = "yes" -o "$mingw32" = "yes" \) ; then
>          werror="yes"
>      else
>          werror="no"

Reviewed-by: Daniel P. Berrange <address@hidden>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|