Re: [Qemu-devel] [PATCH v2] Makefile: add dependency on scripts/create_config

[Peter Maydell]

On 7 June 2016 at 13:07, Paolo Bonzini <address@hidden> wrote:
> Make sure that config-host.h and config-target.h are rebuilt whenever
> there is a change in the scripts that generates them; add the dependency
> to the pattern rule as suggested by Peter.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  rules.mak | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rules.mak b/rules.mak
> index 4a8f464..fae16b3 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -172,7 +172,7 @@ TRACETOOL=$(PYTHON) $(SRC_PATH)/scripts/tracetool.py
>  config-%.h: config-%.h-timestamp
>         @cmp $< $@ >/dev/null 2>&1 || cp $< $@
>
> -config-%.h-timestamp: config-%.mak
> +config-%.h-timestamp: config-%.mak $(SRC_PATH)/scripts/create_config
>         $(call quiet-command, sh $(SRC_PATH)/scripts/create_config < $< > $@, 
> "  GEN   $(TARGET_DIR)config-$*.h")
>
>  .PHONY: clean-timestamp
> --
> 1.8.3.1

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM