Re: [Qemu-devel] [PATCH 1/3] Makefile: add dependency on scripts/create_config

[Peter Maydell]

On 7 June 2016 at 12:48, Paolo Bonzini <address@hidden> wrote:
> Make sure that config-host.h and config-target.h are rebuilt whenever
> there is a change in the scripts that generates them.
>
> Reported-by: Peter Maydell <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  Makefile        | 2 +-
>  Makefile.target | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 59af636..9e0e1f8 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -168,7 +168,7 @@ endif
>  all: $(DOCS) $(TOOLS) $(HELPERS-y) recurse-all modules
>
>  config-host.h: config-host.h-timestamp
> -config-host.h-timestamp: config-host.mak
> +config-host.h-timestamp: config-host.mak $(SRC_PATH)/scripts/create_config
>  qemu-options.def: $(SRC_PATH)/qemu-options.hx
>         $(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@,"  
> GEN   $@")
>
> diff --git a/Makefile.target b/Makefile.target
> index 5b80dd7..0bb5e78 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -37,7 +37,7 @@ PROGS=$(QEMU_PROG) $(QEMU_PROGW)
>  STPFILES=
>
>  config-target.h: config-target.h-timestamp
> -config-target.h-timestamp: config-target.mak
> +config-target.h-timestamp: config-target.mak 
> $(SRC_PATH)/scripts/create_config
>
>  ifdef CONFIG_TRACE_SYSTEMTAP
>  stap: $(QEMU_PROG).stp-installed $(QEMU_PROG).stp 
> $(QEMU_PROG)-simpletrace.stp
> --
> 1.8.3.1

Does it work to add the dependency on the RHS of the pattern rule
instead, like:

config-%.h-timestamp: config-%.mak $(SRC_PATH)/scripts/create_config
        $(call quiet-command, sh $(SRC_PATH)/scripts/create_config <
$< > $@, "  GEN   $(TARGET_DIR)config-$*.h")


?

thanks
-- PMM