[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scsi: mptsas: infinite loop while fetching requ
From: |
P J P |
Subject: |
Re: [Qemu-devel] [PATCH] scsi: mptsas: infinite loop while fetching requests |
Date: |
Tue, 7 Jun 2016 12:12:10 +0530 (IST) |
+-- On Tue, 24 May 2016, P J P wrote --+
| diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c
| index 499c146..be88e16 100644
| --- a/hw/scsi/mptsas.c
| +++ b/hw/scsi/mptsas.c
| @@ -754,11 +754,6 @@ static void mptsas_fetch_request(MPTSASState *s)
| hwaddr addr;
| int size;
|
| - if (s->state != MPI_IOC_STATE_OPERATIONAL) {
| - mptsas_set_fault(s, MPI_IOCSTATUS_INVALID_STATE);
| - return;
| - }
| -
| /* Read the message header from the guest first. */
| addr = s->host_mfa_high_addr | MPTSAS_FIFO_GET(s, request_post);
| pci_dma_read(pci, addr, req, sizeof(hdr));
| @@ -789,6 +784,10 @@ static void mptsas_fetch_requests(void *opaque)
| {
| MPTSASState *s = opaque;
|
| + if (s->state != MPI_IOC_STATE_OPERATIONAL) {
| + mptsas_set_fault(s, MPI_IOCSTATUS_INVALID_STATE);
| + return;
| + }
| while (!MPTSAS_FIFO_EMPTY(s, request_post)) {
| mptsas_fetch_request(s);
| }
Ping..!
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
- Re: [Qemu-devel] [PATCH] scsi: mptsas: infinite loop while fetching requests,
P J P <=