Re: [Qemu-devel] [PATCH] os-posix: include sys/mman.h

[Peter Maydell]

On 6 June 2016 at 13:02, Paolo Bonzini <address@hidden> wrote:
> qemu/osdep.h checks whether MAP_ANONYMOUS is defined, but this
> check is bogus without a previous include of sys/mman.h.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  include/sysemu/os-posix.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/sysemu/os-posix.h b/include/sysemu/os-posix.h
> index 07e3e5a..9c7dfdf 100644
> --- a/include/sysemu/os-posix.h
> +++ b/include/sysemu/os-posix.h
> @@ -26,6 +26,7 @@
>  #ifndef QEMU_OS_POSIX_H
>  #define QEMU_OS_POSIX_H
>
> +#include <sys/mman.h>
>  #include <sys/socket.h>
>  #include <netinet/in.h>
>  #include <netinet/tcp.h>
> --
> 2.5.5

Did you discover this because something broke, or just through
code inspection?

Reviewed-by: Peter Maydell <address@hidden>

We could add mman.h to clean-includes and zap the other includes
of it I guess.

thanks
-- PMM