[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] scsi: esp: check TI buffer index before read
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] scsi: esp: check TI buffer index before read/write |
|
Date: |
Mon, 6 Jun 2016 14:00:03 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 31/05/2016 13:36, P J P wrote:
> + if ((s->rregs[ESP_RSTAT] & STAT_PIO_MASK) == 0) {
> + /* Data out. */
> + qemu_log_mask(LOG_UNIMP, "esp: PIO data read not implemented\n");
> + s->rregs[ESP_FIFO] = 0;
> + esp_raise_irq(s);
> + } else if (s->ti_rptr < s->ti_wptr) {
> s->ti_size--;
> - if ((s->rregs[ESP_RSTAT] & STAT_PIO_MASK) == 0) {
> - /* Data out. */
> - qemu_log_mask(LOG_UNIMP,
> - "esp: PIO data read not implemented\n");
> - s->rregs[ESP_FIFO] = 0;
> - } else {
> - s->rregs[ESP_FIFO] = s->ti_buf[s->ti_rptr++];
> - }
> + s->rregs[ESP_FIFO] = s->ti_buf[s->ti_rptr++];
> esp_raise_irq(s);
> }
> if (s->ti_size == 0) {
Shouldn't this become a "s->ti_rptr == s->ti_wptr" too?
Thanks,
Paolo