Re: [Qemu-devel] [PATCH v8 5/9] linux-user: Update preprocessor constants for Mips-specific e_flags bits

[Leon Alrae]

On Fri, Jun 03, 2016 at 08:43:11PM +0200, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <address@hidden>
> 
> Missing values EF_MIPS_FP64 and EF_MIPS_NAN2008 added, and the format
> of the surrounding code segment adjusted.

Please don't include whitespace fixes of other lines into the same patch:
http://wiki.qemu.org/Contribute/SubmitAPatch#Don.27t_include_irrelevant_changes

If you drop the adjustment of surrounding code then feel free to add:

Reviewed-by: Leon Alrae <address@hidden>

Thanks,
Leon

> 
> Signed-off-by: Thomas Schwinge <address@hidden>
> Signed-off-by: Maciej W. Rozycki <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
>  include/elf.h | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/include/elf.h b/include/elf.h
> index 28d448b..b7f59e4 100644
> --- a/include/elf.h
> +++ b/include/elf.h
> @@ -46,14 +46,16 @@ typedef int64_t  Elf64_Sxword;
>  #define EF_MIPS_ABI_O32              0x00001000      /* O32 ABI.  */
>  #define EF_MIPS_ABI_O64              0x00002000      /* O32 extended for 64 
> bit.  */
>  
> -#define EF_MIPS_NOREORDER 0x00000001
> -#define EF_MIPS_PIC       0x00000002
> -#define EF_MIPS_CPIC      0x00000004
> -#define EF_MIPS_ABI2         0x00000020
> -#define EF_MIPS_OPTIONS_FIRST        0x00000080
> -#define EF_MIPS_32BITMODE    0x00000100
> -#define EF_MIPS_ABI          0x0000f000
> -#define EF_MIPS_ARCH      0xf0000000
> +#define EF_MIPS_NOREORDER       0x00000001
> +#define EF_MIPS_PIC             0x00000002
> +#define EF_MIPS_CPIC            0x00000004
> +#define EF_MIPS_ABI2            0x00000020
> +#define EF_MIPS_OPTIONS_FIRST   0x00000080
> +#define EF_MIPS_32BITMODE       0x00000100
> +#define EF_MIPS_FP64            0x00000200
> +#define EF_MIPS_NAN2008         0x00000400
> +#define EF_MIPS_ABI             0x0000f000
> +#define EF_MIPS_ARCH            0xf0000000
>  
>  /* These constants define the different elf file types */
>  #define ET_NONE   0