Re: [Qemu-devel] [RFC 11/14] console: add dpy_gl_scanout2()

[Gerd Hoffmann]

  Hi,

> @@ -218,6 +218,11 @@ typedef struct DisplayChangeListenerOps {
>      void (*dpy_gl_scanout)(DisplayChangeListener *dcl,
>                             uint32_t backing_id, bool backing_y_0_top,
>                             uint32_t x, uint32_t y, uint32_t w, uint32_t h);
> +    void (*dpy_gl_scanout2)(DisplayChangeListener *dcl,
> +                            int fd, bool backing_y_0_top,
> +                            uint32_t x, uint32_t y, uint32_t w, uint32_t h,
> +                            uint32_t fd_w, uint32_t fd_h, uint32_t fd_stride,
> +                            int fd_fourcc);

Interface looks sane.  I'd like to see a more descriptive name than just
"2" though.  Maybe "dpy_gl_scanout_dmabuf"?  And while being at it
rename the other one to "dpy_gl_scanout_texture"?

Also: please put the spice update into a separate patch.

Adding gtk (or sdl2, or both) support would be nice, to see whenever the
interface works if qemu needs to import the dma-buf for display.

cheers,
  Gerd