[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/10] target-avr: adding AVR interrupt handling
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 05/10] target-avr: adding AVR interrupt handling |
Date: |
Sat, 4 Jun 2016 15:26:01 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 06/02/2016 01:06 PM, Michael Rolnik wrote:
+ } else if (env->intsrc != 0) {
+ vector = __builtin_ffs(env->intsrc);
+ }
Use either ffs (no __builtin) or, preferably, ctz32 from qemu/host-utils.h.
+ env->pc = base + vector * size;
+ env->pc = base + vector * size;
+ env->pc = base + vector * size;
No point replicating this 3 times.
r~
[Qemu-devel] [PATCH 05/10] target-avr: adding AVR interrupt handling, Michael Rolnik, 2016/06/02
[Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation, Michael Rolnik, 2016/06/02
- Re: [Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation, Richard Henderson, 2016/06/04
- Re: [Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation, Michael Rolnik, 2016/06/05
- Re: [Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation, Richard Henderson, 2016/06/05
- Re: [Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation, Michael Rolnik, 2016/06/06
- Re: [Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation, Richard Henderson, 2016/06/06
- Re: [Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation, Michael Rolnik, 2016/06/06
Re: [Qemu-devel] [PATCH 01/10] target-avr: AVR cores support is added. 1. basic CPU structure 2. registers 3. no instructions, Richard Henderson, 2016/06/04