[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] trace: enable tracing in qemu-img
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] trace: enable tracing in qemu-img |
Date: |
Fri, 3 Jun 2016 08:55:18 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/02/2016 12:35 PM, Denis V. Lunev wrote:
> The command will work this way:
> qemu-img --trace qcow2* create -f qcow2 1.img 64G
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> Suggested by: Daniel P. Berrange <address@hidden>
> CC: Eric Blake <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Kevin Wolf <address@hidden>
> ---
> qemu-img.c | 24 +++++++++++++++++++++---
> qemu-img.texi | 34 +++++++++++++++++++++++++++++++++-
> 2 files changed, 54 insertions(+), 4 deletions(-)
>
> @@ -87,7 +89,7 @@ static void QEMU_NORETURN help(void)
> {
> const char *help_msg =
> QEMU_IMG_VERSION
> - "usage: qemu-img command [command options]\n"
> + "usage: qemu-img [common options] command [command options]\n"
> "QEMU disk image utility\n"
This hunk belongs in the previous patch
> "\n"
> "Command syntax:\n"
> @@ -156,10 +158,14 @@ static void QEMU_NORETURN help(void)
> " '-f' first image format\n"
> " '-F' second image format\n"
> " '-s' run in Strict mode - fail on different image size or
> sector allocation\n";
> + const char *help_msg2 =
> + "Common options:\n"
> + " '-T', --trace
> [[enable=]<pattern>][,events=<file>][,file=<file>]\n"
> + " specify tracing options\n";
Part of this hunk belongs in the previous patch, along with mention of
-h/--help as a common option moved up to this area, and adding mention
of -v/--version (once you fix -v to actually work).
> +++ b/qemu-img.texi
> @@ -1,6 +1,6 @@
> @example
> @c man begin SYNOPSIS
> address@hidden @var{command} address@hidden @var{options}]
> address@hidden address@hidden @var{options}] @var{command} address@hidden
> @var{options}]
Again, this hunk belongs in the previous commit.
> @c man end
> @end example
>
> @@ -16,6 +16,38 @@ inconsistent state.
>
> @c man begin OPTIONS
>
> +Common options:
> address@hidden @option
> address@hidden -T, --trace address@hidden,address@hidden
As in patch 3, why does this synopsis vary from the --help output?
Rather than duplicating the same text in multiple .texi files, should we
put the text in a single sub-file then use inclusion to pull it in? That
way, if we ever tweak the common option parsing for --trace, updating
the one sub-file will update all 3 man pages (qemu, qemu-img, qemu-nbd).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 0/5] trace: enable tracing in qemu-io/qemu-nbd/qemu-img, Denis V. Lunev, 2016/06/02
- [Qemu-devel] [PATCH 2/5] trace: enable tracing in qemu-io, Denis V. Lunev, 2016/06/02
- [Qemu-devel] [PATCH 4/5] qemu-img: move common options parsing before commands processing, Denis V. Lunev, 2016/06/02
- [Qemu-devel] [PATCH 5/5] trace: enable tracing in qemu-img, Denis V. Lunev, 2016/06/02
- Re: [Qemu-devel] [PATCH 5/5] trace: enable tracing in qemu-img,
Eric Blake <=
- [Qemu-devel] [PATCH 1/5] trace: move qemu_trace_opts to trace/control.c, Denis V. Lunev, 2016/06/02
- [Qemu-devel] [PATCH 3/5] trace: enable tracing in qemu-nbd, Denis V. Lunev, 2016/06/02