Re: [Qemu-devel] [PATCH v6 13/15] qht: add test-qht-par to invoke qht-bench from 'check' target

[Emilio G. Cota]

On Sun, May 29, 2016 at 23:53:42 +0300, Sergey Fedorov wrote:
> On 25/05/16 04:13, Emilio G. Cota wrote:
> (snip)
> > +
> > +#define TEST_QHT_STRING "tests/qht-bench 1>/dev/null 2>&1 -R -S0.1 -D10000 
> > -N1"
> > +
> > +static void test_qht(int n_threads, int update_rate, int duration)
> > +{
> > +    char *str;
> > +    int rc;
> > +
> > +    str = g_strdup_printf(TEST_QHT_STRING "-n %d -u %d -d %d",
> 
> There needs to be an extra space either at the beginning of the literal
> string, or at the end of the string defined by TEST_QHT_STRING, so that
> we don't get "... -N1-n ...".

Good catch! Changed now.

Thanks,

                Emilio