[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 14/22] mirror: Disable image locking on target ba
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v6 14/22] mirror: Disable image locking on target backing chain |
Date: |
Fri, 3 Jun 2016 16:49:08 +0800 |
In sync=none the backing image of s->target is s->common.bs, which could
be exclusively locked, the image locking wouldn't work here.
Later we can update completion code to lock it after the replaced node
has dropped its lock.
Signed-off-by: Fam Zheng <address@hidden>
---
blockdev.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index fa8b50c..4a9fa7c 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3620,8 +3620,14 @@ void qmp_drive_mirror(const char *device, const char
*target,
/* Mirroring takes care of copy-on-write using the source's backing
* file.
*/
- target_bs = bdrv_open(target, NULL, options, flags | BDRV_O_NO_BACKING,
- errp);
+ flags |= BDRV_O_NO_BACKING;
+ if (sync == MIRROR_SYNC_MODE_NONE) {
+ /* TODO: in mirror complete, after target_bs is switched to and the
+ * original BDS's lock is dropped, we should enable the lock on
+ * target_bs. */
+ flags |= BDRV_O_NO_LOCK;
+ }
+ target_bs = bdrv_open(target, NULL, options, flags, errp);
if (!target_bs) {
goto out;
}
--
2.8.2
- [Qemu-devel] [PATCH v6 06/22] osdep: Introduce qemu_dup, (continued)
- [Qemu-devel] [PATCH v6 06/22] osdep: Introduce qemu_dup, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 08/22] raw-posix: Add image locking support, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 12/22] qemu-nbd: Add "--no-lock/-L" option, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 10/22] qemu-img: Add "-L" option to sub commands, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 13/22] block: Don't lock drive-backup target image in none mode, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 11/22] qemu-img: Update documentation of "-L" option, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 14/22] mirror: Disable image locking on target backing chain,
Fam Zheng <=
- [Qemu-devel] [PATCH v6 17/22] qemu-iotests: 030: Disable image locking when checking test image, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 16/22] qemu-iotests: Wait for QEMU processes before checking image in 091, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 15/22] qemu-iotests: 046: Move version detection out from verify_io, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 18/22] iotests: 087: Disable image locking in cases where file is shared, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 19/22] iotests: Disable image locking in 085, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 20/22] tests: Use null-co:// instead of /dev/null, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 21/22] block: Turn on image locking by default, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 22/22] qemu-iotests: Add test case 153 for image locking, Fam Zheng, 2016/06/03