[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] throttle: refuse iops-size without iops-total/r
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] throttle: refuse iops-size without iops-total/read/write |
|
Date: |
Thu, 2 Jun 2016 10:01:20 -0700 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Wed, Jun 01, 2016 at 05:40:31PM -0700, Stefan Hajnoczi wrote:
> In a similar vein to commit ee2bdc33c913b7d765baa5aa338c29fb30a05c9a
> ("throttle: refuse bps_max/iops_max without bps/iops") it is likely that
> the user made a configuration error if iops-size has been set but no
> iops limit has been set.
>
> Print an error message so the user can check their throttling
> configuration. They should either remove iops-size if they don't want
> any throttling or specify one of iops-total, iops-read, or iops-write.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> tests/test-throttle.c | 10 ++++++++++
> util/throttle.c | 8 ++++++++
> 2 files changed, 18 insertions(+)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
signature.asc
Description: PGP signature