[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/9] AVR cores support is added. 1. basic CPU st
|
From: |
Michael Rolnik |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/9] AVR cores support is added. 1. basic CPU structure 2. registers 3. no instructions |
|
Date: |
Thu, 2 Jun 2016 09:41:53 +0300 |
I ran checkpatch.pl on my patches and it was ok.
I will fix it.
On Thu, Jun 2, 2016 at 9:39 AM, Richard Henderson <address@hidden> wrote:
> On 05/29/2016 06:23 PM, Michael Rolnik wrote:
>
>> +static void avr_cpu_set_pc(
>> + CPUState *cs,
>> + vaddr value)
>>
>
> The formatting throughout all of these patches is wrong.
> You need to follow the instructions in CODING_STYLE.
> You can use ./scripts/checkpatch.pl to catch mistakes.
>
>
> r~
>
--
Best Regards,
Michael Rolnik