[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 04/11] megasas: Fix
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v6 04/11] megasas: Fix |
Date: |
Wed, 01 Jun 2016 10:10:30 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Title "megasas: Fix" is no good, possibly an editing accident. Suggest
something like "megasas: Fix check for msi_init() failure"
Cao jin <address@hidden> writes:
> msi_init returns non-zero value on both failure and success.
>
> cc: Hannes Reinecke <address@hidden>
> cc: Paolo Bonzini <address@hidden>
> cc: Marcel Apfelbaum <address@hidden>
>
> Reviewed-by: Marcel Apfelbaum <address@hidden>
> Signed-off-by: Cao jin <address@hidden>
> ---
> hw/scsi/megasas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
> index a63a581..56fb645 100644
> --- a/hw/scsi/megasas.c
> +++ b/hw/scsi/megasas.c
> @@ -2348,7 +2348,7 @@ static void megasas_scsi_realize(PCIDevice *dev, Error
> **errp)
> "megasas-queue", 0x40000);
>
> if (megasas_use_msi(s) &&
> - msi_init(dev, 0x50, 1, true, false)) {
> + msi_init(dev, 0x50, 1, true, false) < 0) {
> s->flags &= ~MEGASAS_MASK_USE_MSI;
> }
> if (megasas_use_msix(s) &&
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v6 04/11] megasas: Fix,
Markus Armbruster <=