[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] including the "git describe" output in the QEMU binarie
Re: [Qemu-devel] including the "git describe" output in the QEMU binaries?
Tue, 31 May 2016 14:16:25 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0
On 05/31/16 13:32, Daniel P. Berrange wrote:
> On Tue, May 31, 2016 at 01:16:14PM +0200, Laszlo Ersek wrote:
>> has this been raised / considered before? To me at least it would be
>> extremely useful if QEMU binaries built from a git working directory
>> returned the output of "git describe" (+ possibly a hint about an
>> unclean working directory), when invoked with "-version".
>> Not volunteering for the implementation, and also not suggesting /
>> requesting that others implement it (everyone is busy with real stuff,
>> I'm sure); just asking if it's been considered.
> Currently configure supports a --pkgversion flag which is used by people
> packaging QEMU in RPM/Debs to include their arbitrary custom version string.
> This information is then reported by -version and the appropriate QMP
> We could quite easily make configure default the pkgversion to the current
> GIT hash if --pkgversion is not explicitly given.
That sounds great, thanks! I'll try to post a patch. I'm thinking of
git-describe, plus appending a plus sign (+), when there are uncommitted
changes (for which I plan to look with ( ! git diff --quiet || ! git
diff --staged --quiet )).