[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-block] [PATCH v19 08/10] Implement new driver for

From: Changlong Xie
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v19 08/10] Implement new driver for block replication
Date: Tue, 31 May 2016 09:20:15 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 05/31/2016 02:14 AM, Stefan Hajnoczi wrote:
On Fri, May 20, 2016 at 03:36:18PM +0800, Changlong Xie wrote:
+        /* start backup job now */
+        error_setg(&s->blocker,
+                   "block device is in use by internal backup job");
+        top_bs = bdrv_lookup_bs(s->top_id, s->top_id, errp);
+        if (!top_bs || !check_top_bs(top_bs, bs)) {
+            reopen_backing_file(s, false, NULL);
+            aio_context_release(aio_context);
+            return;
+        }

Missing error_setg() with an error message when check_top_bs() fails.

Will add.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]