[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 16/19] linux-user: Restart fork() if signals pend
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH v2 16/19] linux-user: Restart fork() if signals pending |
Date: |
Fri, 27 May 2016 15:51:58 +0100 |
From: Timothy E Baldwin <address@hidden>
If there is a signal pending during fork() the signal handler will
erroneously be called in both the parent and child, so handle any
pending signals first.
Signed-off-by: Timothy Edward Baldwin <address@hidden>
Message-id: address@hidden
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
---
linux-user/syscall.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 549f571..7d5f123 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -4796,6 +4796,11 @@ static int do_fork(CPUArchState *env, unsigned int
flags, abi_ulong newsp,
if ((flags & ~(CSIGNAL | CLONE_NPTL_FLAGS2)) != 0) {
return -TARGET_EINVAL;
}
+
+ if (block_signals()) {
+ return -TARGET_ERESTARTSYS;
+ }
+
fork_start();
ret = fork();
if (ret == 0) {
--
1.9.1
- [Qemu-devel] [PATCH v2 00/19] linux-user: fix various signal race conditions, Peter Maydell, 2016/05/27
- [Qemu-devel] [PATCH v2 16/19] linux-user: Restart fork() if signals pending,
Peter Maydell <=
- [Qemu-devel] [PATCH v2 18/19] linux-user: Avoid possible misalignment in host_to_target_siginfo(), Peter Maydell, 2016/05/27
- [Qemu-devel] [PATCH v2 14/19] linux-user: Restart exit() if signal pending, Peter Maydell, 2016/05/27
- [Qemu-devel] [PATCH v2 11/19] linux-user: Queue synchronous signals separately, Peter Maydell, 2016/05/27
- [Qemu-devel] [PATCH v2 12/19] linux-user: Block signals during sigaction() handling, Peter Maydell, 2016/05/27
- [Qemu-devel] [PATCH v2 13/19] linux-user: pause() should not pause if signal pending, Peter Maydell, 2016/05/27
- [Qemu-devel] [PATCH v2 03/19] linux-user: Fix stray tab-indent, Peter Maydell, 2016/05/27
- [Qemu-devel] [PATCH v2 09/19] linux-user: Remove redundant gdb_queuesig(), Peter Maydell, 2016/05/27
- [Qemu-devel] [PATCH v2 08/19] linux-user: Remove redundant default action check in queue_signal(), Peter Maydell, 2016/05/27
- [Qemu-devel] [PATCH v2 10/19] linux-user: Remove real-time signal queuing, Peter Maydell, 2016/05/27
- [Qemu-devel] [PATCH v2 06/19] linux-user: Use safe_syscall for sigsuspend syscalls, Peter Maydell, 2016/05/27