[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/12] Introduce TCGOpcode for fence instruct
From: |
Pranith Kumar |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/12] Introduce TCGOpcode for fence instruction |
Date: |
Fri, 27 May 2016 10:16:15 -0400 |
Sergey Fedorov writes:
> On 27/05/16 04:00, Richard Henderson wrote:
>> diff --git a/tcg/tcg-opc.h b/tcg/tcg-opc.h
>> index 6d0410c..b772d90 100644
>> --- a/tcg/tcg-opc.h
>> +++ b/tcg/tcg-opc.h
>> @@ -42,6 +42,8 @@ DEF(br, 0, 0, 1, TCG_OPF_BB_END)
>> # define IMPL64 TCG_OPF_64BIT
>> #endif
>>
>> +DEF(fence, 0, 0, 0, TCG_OPF_SIDE_EFFECTS)
>> +
>
> I still think this TCG op needs to have a constant argument of a barrier
> type. So that we can distinguish between full, read and write memory
> barriers.
>
Yes, I have a version with this fixed. I will post my patches(v3) with this
changed.
Thanks,
--
Pranith
- [Qemu-devel] [PATCH v2 00/12] tcg: Add fence opcode, Richard Henderson, 2016/05/26
- [Qemu-devel] [PATCH v2 03/12] tcg/aarch64: Add support for fence, Richard Henderson, 2016/05/26
- [Qemu-devel] [PATCH v2 04/12] tcg/arm: Add support for fence, Richard Henderson, 2016/05/26
- [Qemu-devel] [PATCH v2 01/12] Introduce TCGOpcode for fence instruction, Richard Henderson, 2016/05/26
- [Qemu-devel] [PATCH v2 06/12] tcg/mips: Add support for fence, Richard Henderson, 2016/05/26
- [Qemu-devel] [PATCH v2 05/12] tcg/ia64: Add support for fence, Richard Henderson, 2016/05/26
- [Qemu-devel] [PATCH v2 08/12] tcg/s390: Add support for fence, Richard Henderson, 2016/05/26
- [Qemu-devel] [PATCH v2 09/12] tcg/sparc: Add support for fence, Richard Henderson, 2016/05/26
- [Qemu-devel] [PATCH v2 02/12] tcg/i386: Add support for fence, Richard Henderson, 2016/05/26
- [Qemu-devel] [PATCH v2 07/12] tcg/ppc: Add support for fence, Richard Henderson, 2016/05/26
- [Qemu-devel] [PATCH v2 10/12] tcg/tci: Add support for fence, Richard Henderson, 2016/05/26