[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model |
Date: |
Fri, 27 May 2016 11:40:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
On 27/05/2016 04:13, xiaoqiang zhao wrote:
>
>
> 在 2016年05月25日 21:15, Paolo Bonzini 写道:
>>>>> @@ -310,8 +312,7 @@ static void pl011_class_init(ObjectClass *oc,
>>>>> void *data)
>>>>> >> >
>>>>> >> > dc->realize = pl011_realize;
>>>>> >> > dc->vmsd = &vmstate_pl011;
>>>>> >> >- /* Reason: realize() method uses
>>>>> qemu_char_get_next_serial() */
>>>>> >> >- dc->cannot_instantiate_with_device_add_yet = true;
>>> >Why does instantiating with device_add work now? There's
>>> >still no way to wire up interrupt lines or map mmio regions.
>>> >(This has never made much sense to me -- Markus?)
>> You can create it with -device if your board provides a platform bus and
>> there's an FDT creator function. If you don't, you get an error.
>>
>> Regarding device_add, it's disabled anyway because sysbus is not
>> hotpluggable.
>>
>> Eiter way it's safe to remove this line, which is for outliers that
>> otherwise would not give any error message.
> Paolo: Do I need to send a new version to keep the
>
> "dc->cannot_instantiate_with_device_add_yet = true"
> untouched ?
No, you should remove it. cannot_instantiate_with_device_add_yet is set
if you cannot_instantiate_with_device_add_yet *and* there is no code
elsewhere to detect that.
Thanks,
Paolo
- [Qemu-devel] [PATCH 0/6] Drop the qemu_char_get_next_serial function, xiaoqiang zhao, 2016/05/25
- [Qemu-devel] [PATCH 3/6] hw/char: QOM'ify digic-uart model, xiaoqiang zhao, 2016/05/25
- [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model, xiaoqiang zhao, 2016/05/25
- Re: [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model, xiaoqiang zhao, 2016/05/26
- Re: [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model, Peter Maydell, 2016/05/27
- Re: [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model, Paolo Bonzini, 2016/05/27
- Re: [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model, xiaoqiang zhao, 2016/05/27
- Re: [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model, Markus Armbruster, 2016/05/30
[Qemu-devel] [PATCH 5/6] hw/char: QOM'ify xilinx_uartlite model, xiaoqiang zhao, 2016/05/25
[Qemu-devel] [PATCH 2/6] hw/char: QOM'ify cadence_uart model, xiaoqiang zhao, 2016/05/25
[Qemu-devel] [PATCH 6/6] char: get rid of qemu_char_get_next_serial, xiaoqiang zhao, 2016/05/25
[Qemu-devel] [PATCH 4/6] hw/char: QOM'ify stm32f2xx_usart model, xiaoqiang zhao, 2016/05/25