qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 for-2.7 00/28] Convert migration to QIOChanne


From: Amit Shah
Subject: Re: [Qemu-devel] [PATCH v6 for-2.7 00/28] Convert migration to QIOChannel & support
Date: Thu, 26 May 2016 11:47:42 +0530

On (Wed) 27 Apr 2016 [11:04:50], Daniel P. Berrange wrote:
> This is an update of patches that were previously posted
> 
>   FYI: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00829.html
>    v1: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg01914.html
>    v2: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg03509.html
>    v3: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg06279.html
>    v4: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg02769.html
>    v5: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg04591.html
> 
> There are no functional changes since v5 posting. This is just a
> rebase to resolve conflicts against master. From my POV this is
> ready for 2.7.

Thanks, I've applied this series, and sent a pull req.

I've rebased it to master, which caused a few patches to change (but
not significantly.  Majority changes were the dropping of x- in
autoconverge, and the change from qjson.c to migration/qjson.c in
Makefiles.

I've also updated the 'Since 2.6' to 'Since 2.7' in the qapi
descriptions.

Each patch compiles fine, and the diffstat is the same (except for one
patch in migration.c, which did not need wrapping after the x- drop).

The only outstanding request I see is from Juan and me to consider
renaming of the functions that start migrations; that can be addressed
in a follow-up series.

Dan, can you also fill up a feature page (or two) for this series
based on the template here:

http://qemu-project.org/NewFeatureTemplate

that'll help with testing efforts.  I've seen the extensive
documentation on your blog, links to them will be great.

Thanks!

                Amit



reply via email to

[Prev in Thread] Current Thread [Next in Thread]