[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 19/27] qemu-iotests: 140: Disable image lock
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v5 19/27] qemu-iotests: 140: Disable image lock for qemu-io access |
Date: |
Wed, 25 May 2016 15:16:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 17.05.2016 09:35, Fam Zheng wrote:
> The VM is still on, the image locking check would complain.
No, it wouldn't. We are opening an NBD URL that is provided by the VM.
Even if it would, we are only reading data, so an -r would probably be
better than an -L.
Max
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> tests/qemu-iotests/140 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/140 b/tests/qemu-iotests/140
> index 49f9df4..3be656a 100755
> --- a/tests/qemu-iotests/140
> +++ b/tests/qemu-iotests/140
> @@ -70,7 +70,7 @@ _send_qemu_cmd $QEMU_HANDLE \
> 'arguments': { 'device': 'drv' }}" \
> 'return'
>
> -$QEMU_IO_PROG -f raw -c 'read -P 42 0 64k' \
> +$QEMU_IO_PROG -f raw -L -c 'read -P 42 0 64k' \
> "nbd+unix:///drv?socket=$TEST_DIR/nbd" 2>&1 \
> | _filter_qemu_io | _filter_nbd
>
>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v5 15/27] qemu-img: Update documentation of "-L" option, (continued)
- [Qemu-devel] [PATCH v5 14/27] qemu-img: Add "-L" option to sub commands, Fam Zheng, 2016/05/17
- [Qemu-devel] [PATCH v5 13/27] qemu-io: Add "-L" option for BDRV_O_NO_LOCK, Fam Zheng, 2016/05/17
- [Qemu-devel] [PATCH v5 17/27] block: Don't lock drive-backup target image in none mode, Fam Zheng, 2016/05/17
- [Qemu-devel] [PATCH v5 18/27] mirror: Disable image locking on target backing chain, Fam Zheng, 2016/05/17
- [Qemu-devel] [PATCH v5 19/27] qemu-iotests: 140: Disable image lock for qemu-io access, Fam Zheng, 2016/05/17
- Re: [Qemu-devel] [PATCH v5 19/27] qemu-iotests: 140: Disable image lock for qemu-io access,
Max Reitz <=
- [Qemu-devel] [PATCH v5 21/27] qemu-iotests: Wait for QEMU processes before checking image in 091, Fam Zheng, 2016/05/17
- [Qemu-devel] [PATCH v5 20/27] qemu-iotests: 046: Move version detection out from verify_io, Fam Zheng, 2016/05/17
- [Qemu-devel] [PATCH v5 23/27] iotests: 087: Disable image lock in cases where file is shared, Fam Zheng, 2016/05/17
- [Qemu-devel] [PATCH v5 22/27] qemu-iotests: 030: Disable image lock when checking test image, Fam Zheng, 2016/05/17
- [Qemu-devel] [PATCH v5 24/27] iotests: Disable image locking in 085, Fam Zheng, 2016/05/17