qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 06/14] stream: Use BlockBackend for I/O


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 06/14] stream: Use BlockBackend for I/O
Date: Tue, 24 May 2016 18:27:40 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 05/24/2016 07:47 AM, Kevin Wolf wrote:
> This changes the streaming block job to use the job's BlockBackend for
> performing the COR reads. job->bs isn't used by the streaming code any
> more afterwards.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/io.c            |  9 ---------
>  block/stream.c        | 15 +++++++++------
>  include/block/block.h |  2 --
>  trace-events          |  1 -
>  4 files changed, 9 insertions(+), 18 deletions(-)
> 

> +++ b/trace-events
> @@ -72,7 +72,6 @@ bdrv_aio_readv(void *bs, int64_t sector_num, int 
> nb_sectors, void *opaque) "bs %
>  bdrv_aio_writev(void *bs, int64_t sector_num, int nb_sectors, void *opaque) 
> "bs %p sector_num %"PRId64" nb_sectors %d opaque %p"
>  bdrv_aio_write_zeroes(void *bs, int64_t sector_num, int nb_sectors, int 
> flags, void *opaque) "bs %p sector_num %"PRId64" nb_sectors %d flags %#x 
> opaque %p"
>  bdrv_co_readv(void *bs, int64_t sector_num, int nb_sector) "bs %p sector_num 
> %"PRId64" nb_sectors %d"
> -bdrv_co_copy_on_readv(void *bs, int64_t sector_num, int nb_sector) "bs %p 
> sector_num %"PRId64" nb_sectors %d"

Yay - one less sector-based trace point - we're slowly getting to an
all-bytes destination.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]