Re: [Qemu-devel] [PATCH 03/33] acpi: add aml_refof()

[Marcel Apfelbaum]

On 05/17/2016 05:42 PM, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>   hw/acpi/aml-build.c         | 8 ++++++++
>   include/hw/acpi/aml-build.h | 1 +
>   2 files changed, 9 insertions(+)
>
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index f7d99be..95f6021 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -1416,6 +1416,14 @@ Aml *aml_unicode(const char *str)
>       return var;
>   }
>
> +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefRefOf */
> +Aml *aml_refof(Aml *arg)
> +{
> +    Aml *var = aml_opcode(0x71 /* RefOfOp */);
> +    aml_append(var, arg);
> +    return var;
> +}
> +
>   /* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefDerefOf */
>   Aml *aml_derefof(Aml *arg)
>   {
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index 70a4b14..dd432d2 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -359,6 +359,7 @@ Aml *aml_create_qword_field(Aml *srcbuf, Aml *index, const 
> char *name);
>   Aml *aml_varpackage(uint32_t num_elements);
>   Aml *aml_touuid(const char *uuid);
>   Aml *aml_unicode(const char *str);
> +Aml *aml_refof(Aml *arg);
>   Aml *aml_derefof(Aml *arg);
>   Aml *aml_sizeof(Aml *arg);
>   Aml *aml_concatenate(Aml *source1, Aml *source2, Aml *target);

Reviewed-by: Marcel Apfelbaum <address@hidden>

Thanks,
Marcel